# HG changeset patch # User Jeff Hammel # Date 1295748676 28800 # Node ID 3f94c56f8f4719948dc3001c29a16d3d6505efad # Parent 60e307e74829ccc3ff9c1b7cbc09ea64afbdfeb5 further abstraction ::sigh:: diff -r 60e307e74829 -r 3f94c56f8f47 autobot/changes/poller.py --- a/autobot/changes/poller.py Sat Jan 22 17:58:41 2011 -0800 +++ b/autobot/changes/poller.py Sat Jan 22 18:11:16 2011 -0800 @@ -185,23 +185,28 @@ % (self.name, self.changeCount, revList, self.workdir) ) # get metadata for changes and send them to master - _dl = [] + d = defer.succeed() for rev in revList: - self.commitInfo = {} + d.addCallback(self._process_change, rev) + + return d - # get metadata - dl = defer.DeferredList([ - self._get_commit_timestamp(rev), - self._get_commit_name(rev), - self._get_commit_files(rev), - self._get_commit_comments(rev), - ], consumeErrors=True) + def _process_change(self, rev): + self.commitInfo = {} + log.msg('%s: processing change %s' % rev) + d = defer.succeed(None) + return d +# # get metadata +# dl = defer.DeferredList([ +# self._get_commit_timestamp(rev), +# self._get_commit_name(rev), +# self._get_commit_files(rev), +# self._get_commit_comments(rev), +# ], consumeErrors=True) - # add the change, apparently - dl.addCallback(self._add_change, rev) - _dl.append(dl) - return defer.DeferredList(_dl) - return d +# # add the change, apparently +# dl.addCallback(self._add_change, rev) + def _add_change(self, change): log.msg("_add_change results")