# HG changeset patch # User Jeff Hammel # Date 1300755356 25200 # Node ID 6fd14e71065050bd234a6ea2cf7932447ecaf3a9 # Parent b73ccb5bf33790ba4a193407ec40853962f27e71 flush out comments diff -r b73ccb5bf337 -r 6fd14e710650 autobot/process/factory.py --- a/autobot/process/factory.py Mon Mar 21 17:52:14 2011 -0700 +++ b/autobot/process/factory.py Mon Mar 21 17:55:56 2011 -0700 @@ -81,6 +81,10 @@ # http://mxr.mozilla.org/mozilla-central/source/build/package/mac_osx/unpack-diskimage # http://hg.mozilla.org/qa/mozmill-automation/file/default/libs/install.py # ideally, the duplication of intent should be disappeared + # probably in the short term, a python script should be written + # as part of autobot, since currently the slaves will need this + # In the longer term, a silly python package should be thrown on + # pypi that does this and all other implementations destroyed self.addStep(ShellCommand(command=['rm', '-rf', 'firefox-tmp'])) self.addStep(ShellCommand(command=['mkdir', 'firefox-tmp'], haltOnFailure=True)) @@ -108,6 +112,7 @@ # code islands self.addStep(SetProperty(property='firefox', command=self.abspath(WithProperties('firefox/%(app_name)s/Contents/MacOS/firefox-bin')))) + else: raise NotImplementedError("FirefoxDownloader doesn't know how to work with your os: %s" % platform['os'])