# HG changeset patch
# User Jeff Hammel <jhammel@mozilla.com>
# Date 1332884473 25200
# Node ID 135322cc5bc08c8f772441e1429844f840bbf90c
# Parent  18f8107aa4f9f66d105d84b5e6d345e760915732
document this

diff -r 18f8107aa4f9 -r 135322cc5bc0 configuration/config.py
--- a/configuration/config.py	Tue Mar 27 14:23:39 2012 -0700
+++ b/configuration/config.py	Tue Mar 27 14:41:13 2012 -0700
@@ -325,7 +325,9 @@
         """
         parse configuration including command line options
         - args: command line arguments to parse (default: system arguments)
-        - parser
+        - parser: a parser instance
+        - config_provider_option: option for configuration files; if None,
+          will be taken from remaining args
         """
 
         # parse arguments
@@ -343,7 +345,7 @@
                                if key in parser.parsed])
 
         # deserialize configuration
-        configuration_files = getattr(options, 'load', [])
+        configuration_files = getattr(options, 'load', args)
         missing = [i for i in configuration_files
                    if not os.path.exists(i)]
         if missing:
@@ -360,7 +362,7 @@
         try:
             # generate configuration
             self(*config)
-        except MissingValueException, e:
+        except MissingValueException, missingvalues:
             pass
 
         # dump configuration, if specified
@@ -371,7 +373,7 @@
 
         if missingvalues and not dump:
             # XXX assuming if you don't have values you were just dumping
-            parser.error(str(e))
+            raise missingvalues
 
         # return parsed arguments
         return options, args