# HG changeset patch
# User Jeff Hammel <jhammel@mozilla.com>
# Date 1332867171 25200
# Node ID a1f8dec4d4f910c7546a1ad159c5be63acd667b3
# Parent  d218df4d0b4cd29144e023f59faa4e15c616ae05
we has another broken test

diff -r d218df4d0b4c -r a1f8dec4d4f9 configuration/config.py
--- a/configuration/config.py	Tue Mar 27 09:40:15 2012 -0700
+++ b/configuration/config.py	Tue Mar 27 09:52:51 2012 -0700
@@ -5,6 +5,7 @@
 """
 
 import copy
+import os
 import sys
 import optparse
 
@@ -203,6 +204,8 @@
                     else:
                         required_message = "Parameter %s is required but not present" % key
                     # TODO: more specific exception
+                    # Also, this should probably raise all missing values vs
+                    # one by one
                     raise MissingValueException(required_message)
         # TODO: configuration should be locked after this is called
 
diff -r d218df4d0b4c -r a1f8dec4d4f9 tests/unit.py
--- a/tests/unit.py	Tue Mar 27 09:40:15 2012 -0700
+++ b/tests/unit.py	Tue Mar 27 09:52:51 2012 -0700
@@ -52,12 +52,15 @@
         self.assertTrue(isinstance(json_provider, configuration.JSON))
 
         # serialize to a temporary file
-        filename = tempfile.mktemp()
+        filename = tempfile.mktemp(suffix='.json')
+        self.assertFalse(os.path.exists(filename))
         config = {'browser_path': '/home/jhammel/bin/firefox',
                   'activeTests':  ['ts']}
         example(config)
         config['test_timeout'] = 1200 # default
         self.assertEqual(config, example.config)
+        example.serialize(filename)
+        self.assertTrue(os.path.exists(filename))
         if os.path.exists(filename):
             os.remove(filename)