# HG changeset patch
# User Jeff Hammel <jhammel@mozilla.com>
# Date 1335686749 25200
# Node ID bfe4234ee6f4126e6ea7f7825c2240ca5750d1a2
# Parent  290c40224e5d8cbebe1a59c5cfb1b69bfe6358fd
better ordering of processing for dump()

diff -r 290c40224e5d -r bfe4234ee6f4 configuration/configuration.py
--- a/configuration/configuration.py	Sun Apr 29 00:30:58 2012 -0700
+++ b/configuration/configuration.py	Sun Apr 29 01:05:49 2012 -0700
@@ -420,12 +420,13 @@
     def dump(self, options, missingvalues):
         """dump configuration, if specified"""
 
+        if missingvalues:
+            self.error(str(missingvalues))
+
         dump = getattr(options, 'dump')
         if dump:
             # TODO: have a way of specifying format other than filename
             self.serialize(dump)
-        elif missingvalues:
-            self.error(str(missingvalues))
 
     ### serialization/deserialization