changeset 83:42cdcb431462

some factory tidying
author Jeff Hammel <jhammel@mozilla.com>
date Tue, 11 Jan 2011 17:43:09 -0800
parents eec994731866
children 86e65422f31a
files autobot/projects/logparser/__init__.py autobot/projects/mozmill/__init__.py
diffstat 2 files changed, 8 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/autobot/projects/logparser/__init__.py	Tue Jan 11 17:23:46 2011 -0800
+++ b/autobot/projects/logparser/__init__.py	Tue Jan 11 17:43:09 2011 -0800
@@ -14,5 +14,6 @@
                                  hg_sources=['http://hg.mozilla.org/automation/logparser/'])
 
     # run the tests
-    self.addStep(ShellCommand(command=[WithProperties('%(python)s', 'test_logparser.py'],
-                              workdir=WithProperties('%(virtualenv)s/src/logparser/logparser')))
+    self.addStep(ShellCommand(command=[WithProperties('%(python)s'), 'test_logparser.py'],
+                              workdir=WithProperties('%(virtualenv)s/src/logparser/logparser'),
+                              description='test logparser'))
--- a/autobot/projects/mozmill/__init__.py	Tue Jan 11 17:23:46 2011 -0800
+++ b/autobot/projects/mozmill/__init__.py	Tue Jan 11 17:43:09 2011 -0800
@@ -1,6 +1,6 @@
-from autobot.process.factory import VirtualenvFactory
+from autobot.process.factory import PythonSourceFactory
 
-class TestMozmillFactory(VirtualenvFactory):
+class TestMozmillFactory(PythonSourceFactory):
   """
   factory to test Mozmill
   http://github.com/mozautomation/mozmill
@@ -8,12 +8,10 @@
   def __init__(self):
 
     # setup the environment
-    VirtualenvFactory.__init__(self, name='mozmill',
-                               git_sources=['http://github.com/mozautomation/mozmill'])
-
-    # install the python
-    # TODO: utilize PythonSourceFactory
+    PythonSourceFactory.__init__(self, name='mozmill',
+                                 git_sources=['http://github.com/mozautomation/mozmill'])
 
     # get firefox
+    # [TODO]
 
     # run the tests